From 46e7b44ffa0569dcf25775dab7bf9669485d435d Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Fri, 12 Apr 2019 12:35:06 -0400 Subject: [PATCH] inspector: Drop binding info Thia was relying on non-public implementation details and was broken since 2015. --- gtk/inspector/prop-editor.c | 100 ------------------------------------ 1 file changed, 100 deletions(-) diff --git a/gtk/inspector/prop-editor.c b/gtk/inspector/prop-editor.c index a9e186613d..6031a2a295 100644 --- a/gtk/inspector/prop-editor.c +++ b/gtk/inspector/prop-editor.c @@ -1366,105 +1366,6 @@ binding_object_properties (GtkButton *button, GtkInspectorPropEditor *editor) g_signal_emit (editor, signals[SHOW_OBJECT], 0, obj, NULL, "properties"); } -static void -add_binding_info (GtkInspectorPropEditor *editor) -{ - GObject *object; - const gchar *name; - GHashTable *bindings; - GHashTableIter iter; - GBinding *binding; - GtkWidget *row; - GtkWidget *button; - gchar *str; - GObject *other; - const gchar *property; - const gchar *direction; - const gchar *tip; - GtkWidget *label; - - object = editor->priv->object; - name = editor->priv->name; - - /* Note: this is accessing private GBinding details, so keep it - * in sync with the implementation in GObject - */ - bindings = (GHashTable *)g_object_get_data (G_OBJECT (object), "g-binding"); - if (!bindings) - return; - - g_hash_table_iter_init (&iter, bindings); - while (g_hash_table_iter_next (&iter, (gpointer*)&binding, NULL)) - { - if (g_binding_get_source (binding) == object && - g_str_equal (g_binding_get_source_property (binding), name)) - { - other = g_binding_get_target (binding); - property = g_binding_get_target_property (binding); - if (g_binding_get_flags (binding) & G_BINDING_INVERT_BOOLEAN) - { - direction = "↛"; - tip = _("inverted"); - } - else - { - direction = "→"; - tip = NULL; - } - } - else if (g_binding_get_target (binding) == object && - g_str_equal (g_binding_get_target_property (binding), name)) - { - other = g_binding_get_source (binding); - property = g_binding_get_source_property (binding); - if (g_binding_get_flags (binding) & G_BINDING_INVERT_BOOLEAN) - { - direction = "↚"; - tip = _("inverted"); - } - else - { - direction = "←"; - tip = NULL; - } - } - else - continue; - - if (g_binding_get_flags (binding) & G_BINDING_BIDIRECTIONAL) - { - if (g_binding_get_flags (binding) & G_BINDING_INVERT_BOOLEAN) - { - direction = "↮"; - tip = _("bidirectional, inverted"); - } - else - { - direction = "↔"; - tip = _("bidirectional"); - } - } - - row = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 10); - gtk_container_add (GTK_CONTAINER (row), gtk_label_new (_("Binding:"))); - label = gtk_label_new (direction); - if (tip) - gtk_widget_set_tooltip_text (label, tip); - gtk_container_add (GTK_CONTAINER (row), label); - str = g_strdup_printf ("%p :: %s", other, property); - label = gtk_label_new (str); - gtk_container_add (GTK_CONTAINER (row), label); - g_free (str); - button = gtk_button_new_with_label (_("Properties")); - g_object_set_data (G_OBJECT (button), "object", other); - g_signal_connect (button, "clicked", - G_CALLBACK (binding_object_properties), editor); - gtk_container_add (GTK_CONTAINER (row), button); - - gtk_container_add (GTK_CONTAINER (editor), row); - } -} - /* Note: Slightly nasty that we have to poke at the * GSettingsSchemaKey internals here. Keep this in * sync with the implementation in GIO! @@ -1688,7 +1589,6 @@ constructed (GObject *object) add_attribute_info (editor, spec); add_actionable_info (editor); - add_binding_info (editor); add_settings_info (editor); add_gtk_settings_info (editor); } -- 2.30.2